Skip to content

Send requires_payment field to Cinder #23515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diox
Copy link
Member

@diox diox commented May 28, 2025

Fixes mozilla/addons#15596

Testing

(Make sure your env is set to report add-ons to Cinder in your settings)

Not requiring payment scenario:

  • Report an add-on that isn't marked as requiring payment (the default) for hateful content on the page
  • Look at the add-on in the "AMO Dev listings" queue in Cinder
  • In "Details" in the bottom left, scroll down, you should see "Requires payment: FALSE"

Requiring payment scenario:

  • Report an add-on that is marked as requiring payment (can flip the checkbox in devhub for that add-on, or in a shell update the Addon to have requires_payment=True) for hateful content on the page
  • Look at the add-on in the "AMO Dev listings" queue in Cinder
  • In "Details" in the bottom left, scroll down, you should see "Requires payment: TRUE"

@diox diox force-pushed the cinder-requires-payment branch from da75939 to 130cb60 Compare June 2, 2025 10:47
@diox diox marked this pull request as ready for review June 2, 2025 10:47
@diox diox requested review from a team and KevinMind and removed request for a team June 2, 2025 10:47
@KevinMind
Copy link
Contributor

KevinMind commented Jun 2, 2025

Can you clarify for posterity what settings specifically to set for

Make sure your env is set to report add-ons to Cinder in your settings

You could also achieve this by adding a runbook for that and linking the PR here. That would even be preferable as future PRs needing the same setup could benefit from the info.

@KevinMind
Copy link
Contributor

I am also going to need help finding the job in cinder... How do I even get to a list view of the queue in cinder?

I attempted going here and typing the GUID.. got back a list of different guid addons.

I could not find a link to the queue other than a page that displays all of the queues..

@KevinMind
Copy link
Contributor

Verified

Screenshot 2025-06-02 at 20 30 10 Screenshot 2025-06-02 at 20 35 37

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Send "Requires payment" field to Cinder
2 participants